Typically there are two types of swing: flat and upright. Both swings are all correct and effective. Swing types do not affect distance and accuracy at all.
In general, stout golfers who tend to stand over the ball in a bent posture had better swing on a flattish plane, swinging their arms in somewhat the same plane as they turn their shoulders.
Tall, thin golfers who tend to set up in an upright posture are better off swinging on a steep plane, swinging their hands high above their right shoulder.
Ben Hogan who symbolizes a flat swing moved his arms up about the same plane as his shoulders turn while Jack Nicklaus who is regarded as a symbol of an upright swing moved his arms up more vertically or rather on a plane steeper than his shoulders rotate. Hogan and Nicklaus were all great ballstrikers and set incredible records.
Golfers who are strong in the chest, abdominals, back and shoulders would be better off going for a flat one-plane swing as it suits them better. Golfers with a big chest and relatively short arms or with a thick body and little flexibility are those built for power rather than speed. They tend to bend over the ball at address so the clubshaft that is extended upward and the spine that is tilted forward toward the ground are forming a 90-degree angle.
If this is the case for you, you'd better swing on a flat plane, avoiding transferring the bodyweight aggressively to the right on the backswing.
Similarly, you need to keep your head still on the backswing as you don't have to get behind the ball. It is as well to swing the club around your body on the same plane as you turn your shoulders just like a baseball hitter.
Also crucial is to swing your arms and hands inward around the body and turn your body fully on the backswing so that your body turn creates great rotational power. The major source of your power is the full windup, which calls for strength and flexibility as well as strong legs to stabilize your swing.
By this token, you need to avoid pulling the club down with your hands and arms on the downswing. You'd better take care to turn your body as hard as you can, hitting aggressively with your right hand.
You have no difficulty creating a long flat spot at the bottom of the swing arc, which facilitates hitting perfect short irons. For the same reason, however, you may have difficulty getting sufficient height on shots hit with long irons and woods.
To overcome this problem, you'd better strive to make your swing more up-and-down; a good way to attain this is to bend over more at address and protrude your bottom end behind the heels. That forces your shoulders to turn on a more upright plane, enabling you to hit long irons high enough.
A word of caution about shoulder rotation: you'd better turn your shoulders on a slightly steep angle. It prevents you from shifting your bodyweight too much to the right on the backswing despite the danger of reverse weight shift.
Reverse weight shift leading to reverse pivot is a no-no in the traditional swing theory but it can serve as a good method for solid, powerful shots provided that you straighten your right leg slightly as you swing your left hand inward on a circular arc going back. All you have to do to hit the ball firmly is slide your hips toward the target as you tilt your spine back by thrusting your hips upward coming down. That allows your body to have great rotational power, which is geared towards producing powerful draws. The most reliable shot that you can hit under severe pressure situations is a draw. A fade is not for you if you go for a bent posture that matches a flat swing.
However, golfers who are thin or tall with long arms are those built for flexibility and speed rather than power. If you belong to this type of golfer, you had better swing your arms up high above your head on a plane steeper than your shoulders turn.
Assuming the address, keep your arms relaxed and hanging from your shoulders. Stand a tad close to the ball with your left hand in front of the left thigh so that your left arm, hand and clubshaft form a straight line. On the backswing take care to shift your bodyweight to the right, or rather onto your inside hip-joint. Weight shift to the right is critical to generating centrifugal force.
More importantly, resist trying too much to keep your head still. That does nothing but prevent you from transferring your weight to the right, making it hard to create clubhead speed. That also acts as a trigger for a poor rhythm and tempo.
On the downswing you need to focus on swinging the club on a shallow plane through the ball or on a path that is from inside the ball-target line.
To this end, you need to start your downswing by pushing your hips toward the target so you can keep them in front of your arms. That allows your club to move on the correct in-to-out path.
It's also good to initiate your downswing by pulling the club down with the upper part of your left arm. Resist the temptation to hit the ball hard from the top with your hands. Swiping at the ball hard with a brutal force from the top with your right arm and hand brings about nothing but a disaster, ruining your timing and balance. It's always good to endeavor to make an easy, effortless swing.
By the same token, you need to be sure that your downswing is initiated by the unwinding force of your body or reflex action as it encourages rhythm and tempo, plus balance.
For players who are making an upright swing, it's a fade that they can rely on off the tee under tense situations.
As the relatively steep angle of approach to the ball tends to cause the clubface to remain open, you'd better play the ball sufficiently forward in your stance toward your left foot so there is a time enough for the clubface to get square or slightly closed through the ball. Placing the ball too far backward in your stance toward the right foot causes push to the right or push-slice instead of a nice gentle fade.